[Buildbot-devel] [0.7.12rc1] - console problems with order_by_time
Marcus Lindblom
macke at yar.nu
Wed Jan 6 16:11:11 UTC 2010
Hm. That will make it fail when revision is not an int, which was the
whole point of the Aviv's work.
I'd like to see revert only as a last resort option. Can we give it a
few more days?
Cheers,
/Marcus
On 2010-01-06 17:08, Nicolas Sylvain wrote:
> For now I think the best fix is to revert the line. It was modified in
> http://github.com/djmitche/buildbot/commit/83a1c283cf17793f816aab1e2af1f75dc4ea4356
>
>
> - if int(got_rev) < int(revision):
> 0
> + if self.comparator.isRevisionEarlier(
> 0
> + devBuild, builder.getBuild(-1).getChanges()[-1]):
> 0
> break
> I think it's important that we continue to look for "revision" here.
>
>
> Aviv would know, since i'm not 100% sure what his new code needs.
> Aviv: Would just replacing "builder.getBuild(-1).getChanges()[-1]" by
> "revision" make it work? For both of us?
>
>
> Thanks
> Nicolas
>
> On Wed, Jan 6, 2010 at 7:46 AM, Marcus Lindblom <macke at yar.nu
> <mailto:macke at yar.nu>> wrote:
>
> Can this be fixed by using getHeadBuild() that ddunbar added in
> the following commit?
>
> http://github.com/djmitche/buildbot/commit/474be07e38461cb7313fe44fa505115e4b4eb118
>
> Cheers,
> /Marcus
>
>
> On 2010-01-06 16:43, Marc-Antoine Ruel wrote:
>
> An eloquent irc snippet...
>
> 13:15< djmitche> I'm getting console errors and I'm not sure
> what's up
> 13:15< nsylvain> the getBuild(-1) ?
> 13:15< djmitche> yeah, maybe
> 13:16< djmitche> or the getChanges()[-1]?
> 13:16< nsylvain> yeah
> 13:16< nsylvain> that
> 13:16< djmitche> did I miss a fix for that already?
> 13:16< nsylvain> Aviv made a change recently and broke it
> 13:16< djmitche> ah, ok
> 13:16< djmitche> that Aviv
> 13:16< nsylvain> I told Aviv yesterday
> 13:16< djmitche> ok, sorry - I didn't realize it was the
> same bug
> 13:17< nsylvain> If you want a quick fix, we can do one, but
> this is
> going to break his new feature
> 13:17< djmitche> no, I'll revert to 0.7.11p3 and wait for
> the fix
> 13:17< nsylvain> ok
> 13:17< djmitche> sorry to bug you :)
> 13:17< nsylvain> No problem
> 13:17< nsylvain> I better hear it twice than not at all ;)
> 13:17< djmitche> yep
>
>
> On Wed, Jan 6, 2010 at 10:19 AM, Marcus Lindblom<macke at yar.nu
> <mailto:macke at yar.nu>> wrote:
>
> Hi Axel,
>
> Indeed, however there were some commits that supposedly
> fixed this on
> dec 22 by Aviv Ben-Yosef, a.k.a 'abyx':
>
> http://github.com/djmitche/buildbot/commits/release/buildbot/status/web/console.py
>
> I don't know enough about how the console works (it's a
> pretty big
> thing) to figure out what's wrong a.t.m.
>
> Cheers,
> /Marcus
>
> On 2010-01-06 16:13, Axel Hecht wrote:
>
> Hi Marcus,
>
> I'm a tad concerned that the console view doesn't work
> for you. Did
> you figure out why not?
>
> I recall from early discussions that the console view
> at chromium had
> issues with build revisions that are not numeric IDs,
> was that fixed?
> That could be one possible root, as IIRC, you're
> working on mercurial
> where that's not the case.
>
> Axel
>
> 2010/1/6 Marcus Lindblom<macke at yar.nu
> <mailto:macke at yar.nu><mailto:macke at yar.nu
> <mailto:macke at yar.nu>>>
>
> Hi,
>
> Running 0.7.12rc1 with Mercurial, the console is
> by default (with
> order_by_time=False) pretty uninteresting. It
> justs lists useranme
> and revisions-ids for my 10-15 commits in this
> repo. No coloured
> boxes at alls.
>
> When i set order_by_time=True in WebStatus(), I
> get an exception
> in console.py:
>
>
> /vol/home/marcusl/buildbot/work/src/buildbot/status/web/console.py,
> line
> 331 in getBuildsForRevision
> 329
> 330 # Now break if we have enough builds.
> 331 if self.comparator.isRevisionEarlier(
> 332 devBuild,
> builder.getBuild(-1).getChanges()[-1]):
>
> The problem is that builder.getBuild(-1) returns
> an empty tuple
> '()', so naturally the getChanges() call fails
>
> I added a workaround on jinja (now merged to
> master) on the
> followig commit, but I'm not sure if it's the
> right thing to do
>
> http://github.com/djmitche/buildbot/commit/da79b7d10712ce8559ebc421e031588566e55962#diff-0
>
> With this, I get the same output as above, see
> attached html file.
>
> I don't know if the console is supposed to look
> like this by
> default. Either we should fix it or print a
> message saying "sorry,
> no console for you: do XYZ in config, or run the
> ABC vc-system".
>
> Cheers,
> /Marcus
>
>
> ------------------------------------------------------------------------------
> This SF.Net email is sponsored by the Verizon
> Developer Community
> Take advantage of Verizon's best-in-class app
> development support
> A streamlined, 14 day to market process makes app
> distribution
> fast and easy
> Join now and get one step closer to millions of
> Verizon customers
> http://p.sf.net/sfu/verizon-dev2dev
> _______________________________________________
> Buildbot-devel mailing list
> Buildbot-devel at lists.sourceforge.net
> <mailto:Buildbot-devel at lists.sourceforge.net>
> <mailto:Buildbot-devel at lists.sourceforge.net
> <mailto:Buildbot-devel at lists.sourceforge.net>>
> https://lists.sourceforge.net/lists/listinfo/buildbot-devel
>
>
>
>
> ------------------------------------------------------------------------------
> This SF.Net email is sponsored by the Verizon Developer
> Community
> Take advantage of Verizon's best-in-class app development
> support
> A streamlined, 14 day to market process makes app
> distribution fast and easy
> Join now and get one step closer to millions of Verizon
> customers
> http://p.sf.net/sfu/verizon-dev2dev
> _______________________________________________
> Buildbot-devel mailing list
> Buildbot-devel at lists.sourceforge.net
> <mailto:Buildbot-devel at lists.sourceforge.net>
> https://lists.sourceforge.net/lists/listinfo/buildbot-devel
>
>
>
>
More information about the devel
mailing list