[Buildbot-devel] [0.7.12rc1] - console problems with order_by_time

[Marcus Lindblom]

Hi Axel,

Indeed, however there were some commits that supposedly fixed this on 
dec 22 by Aviv Ben-Yosef, a.k.a 'abyx':

http://github.com/djmitche/buildbot/commits/release/buildbot/status/web/console.py

I don't know enough about how the console works (it's a pretty big 
thing) to figure out what's wrong a.t.m.

Cheers,
/Marcus

On 2010-01-06 16:13, Axel Hecht wrote:
> Hi Marcus,
>
> I'm a tad concerned that the console view doesn't work for you. Did 
> you figure out why not?
>
> I recall from early discussions that the console view at chromium had 
> issues with build revisions that are not numeric IDs, was that fixed? 
> That could be one possible root, as IIRC, you're working on mercurial 
> where that's not the case.
>
> Axel
>
> 2010/1/6 Marcus Lindblom <macke at yar.nu <mailto:macke at yar.nu>>
>
>     Hi,
>
>     Running 0.7.12rc1 with Mercurial, the console is by default (with
>     order_by_time=False) pretty uninteresting. It justs lists useranme
>     and revisions-ids for my 10-15 commits in this repo. No coloured
>     boxes at alls.
>
>     When i set order_by_time=True in WebStatus(), I get an exception
>     in console.py:
>
>     /vol/home/marcusl/buildbot/work/src/buildbot/status/web/console.py, line
>     331 in getBuildsForRevision
>     329
>     330        # Now break if we have enough builds.
>     331        if self.comparator.isRevisionEarlier(
>     332          devBuild, builder.getBuild(-1).getChanges()[-1]):
>
>     The problem is that builder.getBuild(-1) returns an empty tuple
>     '()', so naturally the getChanges() call fails
>
>     I added a workaround on jinja (now merged to master) on the
>     followig commit, but I'm not sure if it's the right thing to do
>
>     http://github.com/djmitche/buildbot/commit/da79b7d10712ce8559ebc421e031588566e55962#diff-0
>
>     With this, I get the same output as above, see attached html file.
>
>     I don't know if the console is supposed to look like this by
>     default. Either we should fix it or print a message saying "sorry,
>     no console for you: do XYZ in config, or run the ABC vc-system".
>
>     Cheers,
>     /Marcus
>
>     ------------------------------------------------------------------------------
>     This SF.Net email is sponsored by the Verizon Developer Community
>     Take advantage of Verizon's best-in-class app development support
>     A streamlined, 14 day to market process makes app distribution
>     fast and easy
>     Join now and get one step closer to millions of Verizon customers
>     http://p.sf.net/sfu/verizon-dev2dev
>     _______________________________________________
>     Buildbot-devel mailing list
>     Buildbot-devel at lists.sourceforge.net
>     <mailto:Buildbot-devel at lists.sourceforge.net>
>     https://lists.sourceforge.net/lists/listinfo/buildbot-devel
>
>