[Buildbot-devel] [0.7.12rc1] - console problems with order_by_time

[Marc-Antoine Ruel]

What about changing buildbot.changes.changes.Change to add
self.previous or self.parent_revision? When a ChangeSource is
triggered, it should fill up the information to figure out parent
Change and potentially connect to it.

M-A

On Wed, Jan 6, 2010 at 10:13 AM, Axel Hecht <l10n.moz at googlemail.com> wrote:
> Hi Marcus,
>
> I'm a tad concerned that the console view doesn't work for you. Did you
> figure out why not?
>
> I recall from early discussions that the console view at chromium had issues
> with build revisions that are not numeric IDs, was that fixed? That could be
> one possible root, as IIRC, you're working on mercurial where that's not the
> case.
>
> Axel
>
> 2010/1/6 Marcus Lindblom <macke at yar.nu>
>>
>> Hi,
>>
>> Running 0.7.12rc1 with Mercurial, the console is by default (with
>> order_by_time=False) pretty uninteresting. It justs lists useranme and
>> revisions-ids for my 10-15 commits in this repo. No coloured boxes at alls.
>>
>> When i set order_by_time=True in WebStatus(), I get an exception in
>> console.py:
>>
>> /vol/home/marcusl/buildbot/work/src/buildbot/status/web/console.py, line
>> 331 in getBuildsForRevision
>> 329
>> 330        # Now break if we have enough builds.
>> 331        if self.comparator.isRevisionEarlier(
>> 332          devBuild, builder.getBuild(-1).getChanges()[-1]):
>>
>> The problem is that builder.getBuild(-1) returns an empty tuple
>> '()', so naturally the getChanges() call fails
>>
>> I added a workaround on jinja (now merged to master) on the followig
>> commit, but I'm not sure if it's the right thing to do
>>
>>
>> http://github.com/djmitche/buildbot/commit/da79b7d10712ce8559ebc421e031588566e55962#diff-0
>>
>> With this, I get the same output as above, see attached html file.
>>
>> I don't know if the console is supposed to look like this by default.
>> Either we should fix it or print a message saying "sorry, no console for
>> you: do XYZ in config, or run the ABC vc-system".
>>
>> Cheers,
>> /Marcus
>>
>>
>> ------------------------------------------------------------------------------
>> This SF.Net email is sponsored by the Verizon Developer Community
>> Take advantage of Verizon's best-in-class app development support
>> A streamlined, 14 day to market process makes app distribution fast and
>> easy
>> Join now and get one step closer to millions of Verizon customers
>> http://p.sf.net/sfu/verizon-dev2dev
>> _______________________________________________
>> Buildbot-devel mailing list
>> Buildbot-devel at lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/buildbot-devel
>>
>
>
> ------------------------------------------------------------------------------
> This SF.Net email is sponsored by the Verizon Developer Community
> Take advantage of Verizon's best-in-class app development support
> A streamlined, 14 day to market process makes app distribution fast and easy
> Join now and get one step closer to millions of Verizon customers
> http://p.sf.net/sfu/verizon-dev2dev
> _______________________________________________
> Buildbot-devel mailing list
> Buildbot-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/buildbot-devel
>
>