[Buildbot-devel] [0.7.12rc1] - console problems with order_by_time

[Marcus Lindblom]

Hi,

Running 0.7.12rc1 with Mercurial, the console is by default (with 
order_by_time=False) pretty uninteresting. It justs lists useranme and 
revisions-ids for my 10-15 commits in this repo. No coloured boxes at alls.

When i set order_by_time=True in WebStatus(), I get an exception in 
console.py:

/vol/home/marcusl/buildbot/work/src/buildbot/status/web/console.py, line 
331 in getBuildsForRevision
329
330        # Now break if we have enough builds.
331        if self.comparator.isRevisionEarlier(
332          devBuild, builder.getBuild(-1).getChanges()[-1]):

The problem is that builder.getBuild(-1) returns an empty tuple
'()', so naturally the getChanges() call fails

I added a workaround on jinja (now merged to master) on the followig 
commit, but I'm not sure if it's the right thing to do

http://github.com/djmitche/buildbot/commit/da79b7d10712ce8559ebc421e031588566e55962#diff-0

With this, I get the same output as above, see attached html file.

I don't know if the console is supposed to look like this by default. 
Either we should fix it or print a message saying "sorry, no console for 
you: do XYZ in config, or run the ABC vc-system".

Cheers,
/Marcus
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://buildbot.net/pipermail/devel/attachments/20100106/a8f06253/attachment.htm>