[Buildbot-devel] Slave not recognizing process end

["Martin v. Löwis"]

> Jean-Paul is right - Twisted makes it possible to avoid any race with
> process exit, since you can signal a zombie process (one that has
> exited but not yet been wait()ed on)

Ah, that's the piece that I missed - that you can signal a zombie.

> So the best solution here is to make kill() do nothing if the process
> has already exited.  The ShellCommand.finished() method is called when
> the process exits, so it should be pretty straightforward to add a
> conditional to ShellCommand.kill.  Martin, do you want to give it a
> try?

So how should kill find out that the process already terminated?
AFAICT, finished doesn't set any state.

Also: where does the wait occur for the child process, and who
is calling finished?

Regards,
Martin