[Buildbot-devel] Slave not recognizing process end

["Martin v. Löwis"]

>> The code that's calling signalProcess('KILL') should handle that
>> exception.
>>
>> The exception is present all the way back to Twisted-2.5.0, so it
>> should be safe to catch.
> 
> Why handle the exception rather than changing the code to not try to
> kill processes after they've already exited?  There is no race
> condition.  It's possibly to do this correctly.

I'm not too familiar with the code, but I find that the race condition
is fairly obvious. Something (either the timeout, or the master) may
chose to kill the process, and after the start of processing the
request, before the signal is sent, the process terminates.

How exactly would it be done correctly?

Regards,
Martin