[Buildbot-devel] First release candidate for 0.7.12

[Marcus Lindblom]

On 2010-01-02 20:36, Dustin J. Mitchell wrote:
> On Sat, Jan 2, 2010 at 10:34 AM, Marcus Lindblom<macke at yar.nu>  wrote:
>> I dunno if it helps the above case, but it made the test pass for me.
>
> Hmm, that doesn't work at all for me.  My PYTHONPATH is not set, so I
> added a conditional (if 'PYTHONPATH' not in os.environ).  Then I fixed
> this typo:
>
>       def _master_running(self, res):
> -        out, err, res = r
> +        out, err, res = res

Oops. Sorry about that.

> but then I get:
>
> ===============================================================================
> [FAIL]: buildbot.test.test_limitlogs.MasterLogs.testLog
>
> Traceback (most recent call last):
>    File "/home/dustin/code/buildbot/t/buildbot/buildbot/test/test_limitlogs.py",
> line 94, in _master_running
>      self.failIf(res != 0, "start master failed:\nstdout: %s\nstderr:
> %s" % (out, err))
> twisted.trial.unittest.FailTest: start master failed:
> stdout: Following twistd.log until startup finished..
> 2010-01-02 13:34:18-0600 [-] Log opened.
> 2010-01-02 13:34:18-0600 [-] twistd 8.2.0
> (/home/dustin/code/buildbot/t/buildbot/sandbox/bin/python 2.6.2)
> starting up.
> 2010-01-02 13:34:18-0600 [-] reactor class:
> twisted.internet.selectreactor.SelectReactor.
> 2010-01-02 13:34:18-0600 [-] changes.pck missing, using new one
> 2010-01-02 13:34:18-0600 [-] Creating BuildMaster -- buildbot.version: 0.7.12rc1
> 2010-01-02 13:34:18-0600 [-] loading configuration from
> /tmp/trialtemp/master/master.cfg
> 2010-01-02 13:34:18-0600 [-] this is a mighty long string and I am
> going to write it into the log often
> 2010-01-02 13:34:18-0600 [-] this is a mighty long string and I am
> going to write it into the log often
> 2010-01-02 13:34:18-0600 [-] this is a mighty long string and I am
> going to write it into the log often
> 2010-01-02 13:34:18-0600 [-] this is a mighty long string and I am
> going to write it into the log often
> 2010-01-02 13:34:18-0600 [-] this is a mighty long string and I am
> going to write it into the log often
>
> The buildmaster took more than 10 seconds to start, so we were unable to
> confirm that it started correctly. Please 'tail twistd.log' and look for a
> line that says 'configuration update complete' to verify correct startup.
>
> Any ideas?  At this point I think that this test case is getting a
> *lot* more complex than the code it's testing, so it's tempting to
> just drop the test.

No ideas from here. :-|

If we can't make it work, we should disable it until someone fixes it. 
(It could be good to have in cases when tested code starts to misbehave)

Cheers,
/Marcus