[Buildbot-devel] First release candidate for 0.7.12

[Marcus Lindblom]

On 2010-01-01 19:32, Dustin J. Mitchell wrote:
> On Thu, Dec 31, 2009 at 8:44 PM, Charles Lepple<clepple at gmail.com>  wrote:
>> What bugs me is that I'm seeing "Buildbot needs to be installed" in
>> test_limitlogs.py (the first failure). Do we have a test procedure
>> that takes this into account? Is there a way to do this from the
>> install directory that makes sure we are testing the new code, not
>> what is installed?
>
> Thanks!
>
> I don't know if that test could be configured to run buildbot from the
> build directory, but as written you're right to note that it could
> accidentally test an old buildbot.  The test is really checking how
> well the new format of buildbot.tac works with twistd, and that the
> 'buildbot' executable creates that file correctly.
>
> If we assume that tests are run in a virtualenv, with 'python setup.py
> develop' in effect, then the test is fine.  But I don't see another
> way to run this test effectively.

I meddled with that last week (on the jinja branch, regrettably) when I 
was banging away at making more tests work properly (esp. on windows):

http://github.com/marcusl/buildbot/commit/7ef927159109651e4ff3555f5be1bfeb993619e4

Since 'buildbot' isn't directly runnable on windows (which doesn't find 
it) I changed it to lookup 'python' instead, and add the tested buildbot 
to PYTHONPATH.

I dunno if it helps the above case, but it made the test pass for me.

cheers,
/Marcus