[Buildbot-devel] contrib/git_buildbot.py reports connection lost handling multiple revisions

[Daniel THOMPSON]

On 25/02/10 05:09, Dustin J. Mitchell wrote:
> On Wed, Feb 24, 2010 at 4:44 AM, Daniel THOMPSON <daniel.thompson at st.com> wrote:
>> I can probably modify the script to make a new connection for each
>> change we want to process but I'm not familiar enough with the design to
>> assess if this is an elegant approach. I suspect not...
> 
> Check out the github_buildbot.py script, which we're using for
> buildbot, and which I know can handle submission of simultaneous
> commits.  If you figure out what's wrong, I'll be happy to merge the
> fix upstream.

The difference is that git_buildbot.py uses callLater() to avoid
exploding the stack and github_buildbot.py does not.

The change to introduce callLater() is fairly recent (Dec-2009):
* http://buildbot.net/trac/ticket/645
*
http://github.com/djmitche/buildbot/commit/fb70a1dd799ff16ef9b3002707ed3613c5780c0d

I have applied the inverse patch to my copy of git_buildbot.py and it is
now operating correctly.

I'm not really skilled enough to debug the new code and make the
recursion avoidance work (nor am I blessed with sufficient time to
become so). Thus for for now I'm going to stick with the inverse patch.
However, given the reported for #645 has gone quiet, if you need someone
to test an alternative way to break the recursion then I'd be very happy
to do so.

Many thanks for the advice.

-- 
Daniel Thompson (STMicroelectronics) <daniel.thompson at st.com>
1000 Aztec West, Almondsbury, Bristol, BS32 4SQ. 01454 462659

If a car is a horseless carriage then is a motorcycle a horseless horse?