[Buildbot-devel] Git command fails only via force build

[Dan Savilonis]

Today I noticed that we had a failure when someone pushed force build
on a builder with a git step. The buildslave is Windows with msysgit
and I've never seen this step fail before like this. It seems to
reproduce consistently when I press force build now. This is running
buildbot 0.8.2.

>From the twisted log:
2010-12-08 04:46:35-0500 [-] ShellCommand._startCommand
2010-12-08 04:46:35-0500 [-]  C:\Program Files\Git\cmd\git.CMD reset
--hard a98b71fea9550b173ad9f78c5fd74d6a2ed48928
2010-12-08 04:46:35-0500 [-]   in dir c:\buildbot\cdes\full\build
(timeout 1200 secs)
2010-12-08 04:46:35-0500 [-]   watching logfiles {}
2010-12-08 04:46:35-0500 [-]   argv: ['C:\\Program
Files\\Git\\cmd\\git.CMD', 'reset', '--hard',
'a98b71fea9550b173ad9f78c5fd74d6a2ed48928 ']
2010-12-08 04:46:35-0500 [-]  environment: {---snipped---}
2010-12-08 04:46:35-0500 [-]   closing stdin
2010-12-08 04:46:35-0500 [-]   using PTY: False
2010-12-08 04:46:35-0500 [-] command finished with signal None, exit
code 1, elapsedTime: 0.219000
2010-12-08 04:46:36-0500 [-] _checkAbandoned [Failure instance:
Traceback: <class 'buildbot.slave.commands.base.AbandonChain'>: 1
	C:\Python26\lib\site-packages\buildbot-0.8.0_emc-py2.6.egg\buildbot\slave\commands\base.py:170:processEnded
	C:\Python26\lib\site-packages\buildbot-0.8.0_emc-py2.6.egg\buildbot\slave\commands\base.py:700:finished
	C:\Python26\lib\site-packages\twisted\internet\defer.py:280:callback
	C:\Python26\lib\site-packages\twisted\internet\defer.py:354:_startRunCallbacks
	--- <exception caught here> ---
	C:\Python26\lib\site-packages\twisted\internet\defer.py:371:_runCallbacks
	C:\Python26\lib\site-packages\buildbot-0.8.0_emc-py2.6.egg\buildbot\slave\commands\base.py:948:_abandonOnFailure
	]
2010-12-08 04:46:36-0500 [-]  abandoning chain 1
2010-12-08 04:46:36-0500 [-] SlaveBuilder.commandComplete
<buildbot.slave.commands.vcs.Git instance at 0x0141F5D0>

>From the stdio log:

C:\Program Files\Git\cmd\git.CMD reset --hard
a98b71fea9550b173ad9f78c5fd74d6a2ed48928
 in dir c:\buildbot\cdes\full\build (timeout 1200 secs)
 watching logfiles {}
 argv: ['C:\\Program Files\\Git\\cmd\\git.CMD', 'reset', '--hard',
'a98b71fea9550b173ad9f78c5fd74d6a2ed48928 ']
 environment:
  ---snipped---
 closing stdin
 using PTY: False
'C:\Program' is not recognized as an internal or external command,
operable program or batch file.
elapsedTime=0.218000
program finished with exit code 1

(I cut the env vars out since they were really long and I didn't think
they had any effect on this issue)

It looks like it is having trouble with the spaces in the path, but I
noticed that the last triggered builds (from git update script) worked
fine. Other similar commands like git fetch also work fine. There
hasn't been a triggered build since these failures, but nothing has
changed on the server in the few hours since.

For reference, git fetch is called with these argv:
argv: ['C:\\Program Files\\Git\\cmd\\git.CMD', 'fetch', '-t',
'git at server:repo.git', '+testing']

Any thoughts on what might be happening?

Thanks,
Dan