[Buildbot-devel] buildslave KILL=TERM then KILL

Mon Aug 30 01:56:23 UTC 2010

On Mon, Aug 23, 2010 at 7:57 AM, Jakub Gustak <jgustak at gmail.com> wrote:
> I can provide a patch for this functionality. Do you think it is
> possible to get it included.

I could have sworn Buildbot already did this, but from a brief review
of the source (slave/buildslave/runprocess.py:RunProcess.kill), it
looks like it begins by sending SIGKILL, either through os.kill or
self.process.signalProcess, and if that fails to cause the process to
terminate, it just simulates a termination and leaves the process
running.

So yes, I'd be interested to see a patch to send SIGTERM first!

Dustin

-- 
Open Source Storage Engineer
http://www.zmanda.com