[Buildbot-devel] multi-repo support: build triggers

[Dustin J. Mitchell]

On Sun, Apr 11, 2010 at 7:48 AM, Tobias Oberstein
<tobias.oberstein at tavendo.de> wrote:
> Benoît commented on 4) and didn't like it;) That’s fine, and though I don't agree with all
> his objections, I can see valid points. After playing around with it a bit, I also see
> that it might not be so cool in practice. But hey, it's just an option.

If I recall, his objection was that this moves change filtering from
its usual place - Schedulers - into the hook.

I, too, think this is confusing and suboptimal.  Filtering should
occur in one place - Schedulers.  With a little work (fileIsImportant
or a ChangeFilter) you can already filter on commit message.  We could
certainly expand ChangeFilter to make that easier.

I suspect that doing this filtering in the hook is appealing because
it eliminates the "visual noise" in the waterfall view.  You're right
that this is a display issue, although I don't anticipate any changes
to the waterfall to fix it.

Dustin

-- 
Open Source Storage Engineer
http://www.zmanda.com