[Buildbot-devel] Bug in changes.changes.py

[Dustin J. Mitchell]

On Mon, Sep 7, 2009 at 9:18 AM, Tim Couper<tim at tizmoi.net> wrote:
> as I've found that revision can be an unassigned variable when building
> the kwargs dict. - and the revlink local variable is never used, so I
> suspect that this is a typo?

Close -- 'revision' is always set in any branch of the conditionals,
so it's not unassigned, but it shouldn't be None either.  revlink was,
indeed, a spurious variable.

Fix committed:
  http://github.com/djmitche/buildbot/commit/8d18923c268fdca01d5aff2ae485ecc8c51ffd00

Dustin

-- 
Open Source Storage Engineer
http://www.zmanda.com