[Buildbot-devel] 0.7.10p1 setup command bdist_rpm broken

[Bailey, Darragh]

> -----Original Message-----
> From: Armstrong, Gareth 
> Sent: 31 March 2009 13:59
> To: Bailey, Darragh; buildbot-devel at lists.sourceforge.net
> Subject: RE: 0.7.10p1 setup command bdist_rpm broken
> 
> Hello Darragh,
> 
> Greeting from from an old Galway head. The patch you sent 
> comments out python's decorator syntax.  The real fix for 
> this is to import an external python module like 
> http://pypi.python.org/pypi/DecoratorTools which works on python 2.3.
> 
> Perhaps we need a clear statement on the minimum version of 
> python needed to run buildbot 0.7.10+.
> 
> All the best,
> 
> Gareth

Interesting, well I guess part of the comment I made about the problem being syntax errors relating to python2.3 but not being sure whether the code worked fine on later versions of python applies.

> I've done some digging around and found that these files were 
> suffering from syntax errors when using python 2.3. The code 
> may be perfectly fine for later versions of python, I haven't 
> checked. Changes that I made to allow an rpm to be built are 
> in the patch attached.

I don't believe I use the functionality in the classes that had to be patched anyway, but it definitely would be better if buildbot either decided to go with python 2.4 as the minimum version and had the packages require that, or instead required the DecoratorTools and supported python 2.3 as a minimum version. Don't know if it would work with python2.2 still aswell with this change.

Are the other lines that the patch modified, the "for" expansions, also valid in later versions of python? I have to assume that they are, and buildbot is just not being tested anymore against python 2.3.

--
Regards,
Darragh Bailey

Systems Software Engineer
Hewlett Packard Galway Ltd.

Postal Address:    Hewlett Packard Galway Limited, Ballybrit Business Park, Galway
Registered Office: Hewlett Packard Galway Limited, 63-74 Sir John Rogerson's Quay Dublin 2
Registered Number: 361933