[Buildbot-devel] Source step's clobbering part 2

[Marcus Lindblom]

Hi Axel,

I was more thinking that we replace the clobber-on-branch-change with 
purge, but keep the fallback to clobber if any step fails. Thus 
corrupt-repo behaviour would be preserved.

Quentin (aka 'even') has added a switch for this, keeping the default 
behaviour. See http://github.com/even/buildbot/tree/bug462

I think it looks fairly good (apart from Quentin's question about 
'addFactoryArguments', which someone should look at) and it shouldn't 
break tests and solves the immediate issue.

We could then work on #412 separately, making inrepo-branch switches 
both robust and fast.

Cheers,
/Marcus

Axel Hecht wrote:
> Hi,
> 
> I guess that the clobber-on-branch-change is really a legacy thing, 
> yeah. Not that I know, but it sounds feasible.
> 
> Regarding replacing clobber with purge, I'd rather not. hg itself does 
> end up with corrupted repositories every now and then, in versions prior 
> to 1.0 actually quite frequently. Being able to really clobber when you 
> clobber sounds like the right thing to do for me.
> 
> Axel
> 
> 2009/3/22 Marcus Lindblom <macke-DIcC8dYblPE at public.gmane.org 
> <mailto:macke-DIcC8dYblPE at public.gmane.org>>
> 
>     Hi all,
> 
>     This is regarding a ticket with patch that removes clobbering on
>     inrepo-branch change with Mercurial:
> 
>     See http://buildbot.net/trac/ticket/462.
> 
>     This is basically a rehash of a previous thread:
>     http://thread.gmane.org/gmane.comp.python.buildbot.devel/3899
> 
>     The tests force clobbering (hence I added it when finalizing #187), yet
>     users doesn't seem to want it. (Both Axel and 'even' suggests using 'hg
>     update --clean').
> 
>     What is the rationale for clobbering on branch change? Is it legacy due
>     to CVS?
> 
>     I'd prefer to see this resolved by fixing
>     http://buildbot.net/trac/ticket/412, either by using 'hg purge' as that
>     says, or just delete everything except the '.hg' dir.
> 
>     I suppose similar things goes for Git, Bzr, Darcs and other DVCS:es that
>     keep everything in one dir?
> 
>     Ideas?
> 
>     Cheers,
>     /Marcus
> 
> 
>     ------------------------------------------------------------------------------
>     Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
>     powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
>     easily build your RIAs with Flex Builder, the Eclipse(TM)based
>     development
>     software that enables intelligent coding and step-through debugging.
>     Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
>     _______________________________________________
>     Buildbot-devel mailing list
>     Buildbot-devel at lists.sourceforge.net
>     <mailto:Buildbot-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f at public.gmane.org>
>     https://lists.sourceforge.net/lists/listinfo/buildbot-devel
> 
> 
> 
> ------------------------------------------------------------------------
> 
> ------------------------------------------------------------------------------
> Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
> powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
> easily build your RIAs with Flex Builder, the Eclipse(TM)based development
> software that enables intelligent coding and step-through debugging.
> Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Buildbot-devel mailing list
> Buildbot-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f at public.gmane.org
> https://lists.sourceforge.net/lists/listinfo/buildbot-devel