[Buildbot-devel] review request: #459

[Marcus Lindblom]

Dustin J. Mitchell wrote:
> On Thu, Mar 19, 2009 at 2:24 PM, Marcus Lindblom <macke at yar.nu> wrote:
>> Github.com seems to have some kind of glitch right now. :-/
>>
>> Will check again later.
> 
> The sad octocat gets less and less amusing every time, doesn't it? :)

Indeed. It works now, so I looked at it, but I got in over my head.

I couldn't find anything obviosly wrong, but I had to take most of it on 
faith. (I could understand that you used a big weakref dict, and an 
limited-size LRU with strong refs, but not much more.. ) I really need 
to learn more about the rest of the framework to draw any significant 
conclusions.

Cheers,
/Marcus