[Buildbot-devel] New ticket [Was: MailNotifier annoynace (bug?) #2]

Marcus Lindblom macke at yar.nu
Wed Mar 11 18:28:27 UTC 2009



Ian Zimmerman wrote:
> Ian Zimmerman wrote:
>> in status/mail.py, function message():
>>
>>     if attrs['branch']:
>>         source = "unavailable"
>>     else:
>>         source = ""
>>         if attrs['branch']:
>>             source += "[branch %s] " % attrs['branch']
>>         ...
>>
>> What on earth (or below) is this trying to accomplish?  Is this just a 
>> typo and the first test should look at some other attribute?
>>
>> i
> 
> Submitted ticket for this (# 452).

I've added a patch (via github) and marked it for review. All mail tests 
pass too.

Cheers,
/Marcus





More information about the devel mailing list