[Buildbot-devel] Resubmitted builds do not include properties set at trigger time
dbailey at hp.com
Tue Jun 16 12:23:32 UTC 2009
> -----Original Message-----
> From: Bailey, Darragh
> Sent: 10 June 2009 17:29
> To: buildbot-devel at lists.sourceforge.net
> Subject: [Buildbot-devel] Resubmitted builds do not include
> properties set at trigger time
> I have a triggerable builder that is receives two properties
> from the build steps that trigger it.
> They are set correctly according to the build summary page
> described by the following url:
> /builders/$BUILDERNAME/builds/$BUILDNUM (see
> But if I resubmit this build, the properties are not carried
> through and resent. Since the build factory that is called
> requires these properties (they specify a directory path and
> iso filename) to be able to determine which file to download
> to the client from the master, the builder will always fail.
> Have others encountered this problem or is this a previously
> undiscovered bug? Not seeing any tickets with applicable summaries.
I've done some digging, and it looks to me like it's an omission, so therefore a bug.
Created the following ticket:
Basically it seems to be that if you have properties being passed in via a triggering builder, these will not be included if you resubmit the build for rebuilding.
For my case that is a problem, since the properties basically tell it which iso image file produced by the original build to process.
I can go ahead and add a patch to copy the necessary properties across in my case, but it's not really a good general solution.
Looking at maybe using the property source information to determine which ones to copy. Properties passed in via a trigger scheduler will have have the source set as "Trigger", so it may be sufficient simply to copy through only properties that match this source. Copying all properties is probably a bad idea, so I need some sort of limiter.
Can anyone else suggest whether there might any other ways to filter which properties should be copied through when resubmitting a build?
Systems Software Engineer
Hewlett Packard Galway Ltd.
Postal Address: Hewlett Packard Galway Limited, Ballybrit Business Park, Galway
Registered Office: Hewlett Packard Galway Limited, 63-74 Sir John Rogerson's Quay Dublin 2
Registered Number: 361933
More information about the devel