[Buildbot-devel] Request For Comments/Review : Console view

Nicolas Sylvain nsylvain at chromium.org
Fri Jul 31 14:46:30 UTC 2009

On Fri, Jul 31, 2009 at 2:52 AM, Axel Hecht <l10n.moz at googlemail.com> wrote:

> 2009/7/17 Nicolas Sylvain <nsylvain at chromium.org>
>> Hi Again.
>> A couple important details I forgot in the previous mail:
>> 1. This is not a replacement for the buildbot waterfall. This is just
>> another view. They can both work at the same time.
>> 2. At this point it supports only the source control managers that use
>> incremental integers for their revision id. (Like svn, but not git). I'm
>> still trying to find the best way to fix that, but this won't be trivial.
>> [Short story: to know if a revision is included in a build or not, I do
>> "change.revision <= build.getProperty('got_revision')". So I need to
>> implement "<=" for the other SCMs]
> Your output looks really good, and we'd love to get something like it at
> Mozila. Of course we're on mercurial, so this is a pain point to us.
> Would something like
> change in build.getChanges()

That would work to a certain point, but not "good enough". Suppose that you
have a nightly scheduler, getChanges will return nothing, but yet, you still
want to be able to know what changes made it to this build. Force builds
will also not have changes.

to make hg/git kind of work, we could add code to keep track of the changes
as they come, and keep an ordered list of them. And then we implement the
isRevIncludedInBuild(change_revision, got_revision) using this list. We just
need to handle correctly the case where we don't know about the revision
because maybe it did not trigger a scheduler.


> work across RCSes?
> Axel, jealous.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://buildbot.net/pipermail/devel/attachments/20090731/b50b5c76/attachment.html>

More information about the devel mailing list