[Buildbot-devel] Buildbot unable to kill processes on windows slaves

[Marcus Lindblom]

Jean-Paul Calderone wrote:
> On Tue, 28 Jul 2009 19:55:21 +0200, Marcus Lindblom <macke-DIcC8dYblPE at public.gmane.org> wrote:
>> Jonathan Rogers wrote:
>>> Hi,
>>>
>>> We are having trouble with buildbot being unable to kill off processes
>>> on a windows slave.
>>>
>> There is a ticket in Twisted's Trac for this. That contains a patch that
>> helps with killing off spawned subprocesses.
>>
>> Why it hasn't been folded into the core after a few years, I don't know.
>>
> 
> The currently active Twisted contributors are somewhat short on Windows
> expertise (and, to be honest, interest).  The ticket:
> 
>   http://twistedmatrix.com/trac/ticket/2726
> 
> Has grown to include a mass of subtlety and complexity.  If I had four or
> five days to spend on it, I think I could probably sort it out and come up
> with a solution which was suitable to be included in trunk.  Alas, I don't.
> 
> It's great that the patch on the ticket solves the issue for the buildbot
> users who have tried it out.  The change needs to be suitable for *all*
> Twisted users, though.  A few other details need to be worked out as well,
> like unit tests (the proposed patch includes none), error handling (the
> patch ignores the possibility that the parent might be in a job already,
> and that there are certain permissions required to split off of an existing
> job before a new one can be created).  Much of this is mentioned in comments
> on the ticket, but so far no one has stepped up to address the problems.
> 
> Anyone game to help out?  I'm happy to do shepherd this issue through the
> Twisted development process, but I need someone with the Windows chops to
> actually write some code.

Ouch. It seems to have grown since I looked at it two years ago. :)

Hm. It doesn't seem to be that tricky _if_ you know your way around 
there, but I haven't that much experience with that part of 
python/twisted/windows.. yet.

Also, I'd rather finish the web-template jinja stuff before starting on 
another project. But it's moved up my todo-list.

Cheers,
/Marcus