[Buildbot-devel] Request For Comments/Review : Console view

[Nicolas Sylvain]

On Fri, Jul 17, 2009 at 8:43 AM, Stefan Seefeld <seefeld at sympatico.ca>wrote:

> On 07/17/2009 10:57 AM, Nicolas Sylvain wrote:
>
>>
>>
>> On Fri, Jul 17, 2009 at 7:32 AM, Dustin J. Mitchell <dustin at zmanda.com<mailto:
>> dustin at zmanda.com>> wrote:
>>
>>    I agree -- this looks great!
>>
>> Thanks Dustin!
>>
>>
>>    Given my spotty history of effectively testing Buildbot, I'd like to
>>    hear from at least two people that this patch is working for them
>>    before I commit.  Can you tell I'm trying to democratize the testing
>>    process? :)
>>
>>    The patch is here:
>>
>> http://github.com/nsylvain/buildbot/commit/d609080387d292bc7e873ceadeb0637168488232.patch
>>
>>
>> If you have any problems, let me know. Don't forget to change your
>> buildbot.css!
>> ( cp  /path/to/buildbot/status/web/extended.css
>>  /path/to/master/public_html/buildbot.css )
>>
>> If you copy console.py, console_js.py, console_html.py, extended.css in
>> buildbot/status/web and modify baseweb.py to include the
>> resource, you should be able to make it work on any recent versions (if
>> you are not at head already).
>>
>
> Nicolas,
>
> this is a great view, very compact and well organized. Are you aware that
> Marcus Lindblom is working on a new web frontend that uses the jinja
> templating engine ? It might be worth considering to rewrite these new
> console views to use templates.


I was not aware of this, but if I can get rid of console_html.js I would be
really happy ;)

Nicolas


>
>
> Regards,
>        Stefan
>
> --
>
>      ...ich hab' noch einen Koffer in Berlin...
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://buildbot.net/pipermail/devel/attachments/20090717/e31348e7/attachment.html>