[Buildbot-devel] Request For Comments/Review : Console view

[Nicolas Sylvain]

On Fri, Jul 17, 2009 at 8:10 AM, Jean-Paul Calderone <exarkun at divmod.com>wrote:

> On Fri, 17 Jul 2009 10:32:30 -0400, "Dustin J. Mitchell" <
> dustin at zmanda.com> wrote:
>
>> I agree -- this looks great!
>>
>> Given my spotty history of effectively testing Buildbot, I'd like to
>> hear from at least two people that this patch is working for them
>> before I commit.  Can you tell I'm trying to democratize the testing
>> process? :)
>>
>> The patch is here:
>>
>> http://github.com/nsylvain/buildbot/commit/d609080387d292bc7e873ceadeb0637168488232.patch
>>
>>
> Hey guys,
>
> I'm pretty excited to see this being contributed upstream.  I long for a
> nice view like this. :)
>
> That said, maybe there should be some unit tests to go with it?


I was thinking about that too. Do you have an idea about the best way of
testing such things? I was thinking about having a small test master with
some data in it, and having a way to generate a json file or csv file with
the color of each box, and compare it with what I expect. this is not great
though. (and a lot of work) I'm not really familiar with the current
buildbot unittests, but I heard it's pretty limited.

Nicolas


>
> Jean-Paul
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://buildbot.net/pipermail/devel/attachments/20090717/57128e13/attachment.html>