[Buildbot-devel] DirectoryUpload doesn't upload file completely, still thinks it succeeded

[Sidnei da Silva]

Dustin J. Mitchell <dustin at ...> writes:
> 
> Please do try trunk - Stefan basically rewrote it completely.  If
> you'd prefer to patch your installed version, you'll want
>  
http://github.com/djmitche/buildbot/commit/77ca3ff84ffc8a2f40d060ef628984e1b684cffe.patch
>  
http://github.com/djmitche/buildbot/commit/6f7ea917fc5cc3e2d2bdf7aaabdc1c8bf7e0ba8f.patch

I am now running trunk, and found a small issue already: the tarfile is not
being closed before being removed, which is not cool on Windows. :) I tried to
report a bug but Trac won't let me in. Here's the traceback:

"""
 File "C:\python25\lib\site-packages\twisted\ internet\defer.py", line 328, in
_runCallbacks
    self.result = callback(self.result, *args, **kw)
  File
"c:\python25\lib\site-packages\buildbot-0.7.10-py2.5.egg\
buildbot\slave\commands.py",
line 1010, in finished
    os.remove(self.tarname)
exceptions.WindowsError: [Error 32] The process cannot access the file because
it is being used by another process:
'c:\\docume~1\\admini~1\\locals~1\\temp\\tmpchy1c0'
"""

Adding a simple 'self.fp.close()' before 'os.remove()' should do the trick (I'm
testing this now, but my uplink is very slow).

In other news, it seems like my original issue was actually lack of space in
'/tmp' while uploading, but somehow the master's twistd.log doesn't say
anything, just 'success'. The new version does log a proper exception about it,
so it's a win after all. FTR I'm running this master off a Nokia N810, which has
measly 512k of space in '/tmp' :) Starting the master with 'TMP' and 'TMPDIR'
set to a directory with more space seems to have solved that.

-- Sidnei