[Buildbot-devel] Making BuildRequests merging configurable, rfc

[Axel Hecht]

2009/1/25 Dustin J. Mitchell <dustin at zmanda.com>

> On Thu, Jan 22, 2009 at 5:08 PM, Axel Hecht <l10n.moz at googlemail.com>
> wrote:
> > I tried to expose the functionality without having to import a class and
> > then instantiate it with options at least for the most general case. But
> I'm
> > fine with being overruled here.
>
> I think that importing particular classes for edge cases is not a big
> deal.  In one-oh, I'm adding a "buildbot.config" module which already
> contains all of the relevant symbols, so the need to add imports to
> the config file will be limited.
>
> > The Merge piece in my opinion is really just one way to balance load, and
> > I'd like to add more functionality to the load master.
>
> I like this patch for its flexibility, but I don't see this as a part
> of the load-balancing effort.  I'm also disinclined to try to build a
> significant new load-balancing system in the 0.7.* series.
>
> How would you feel about leaving this as a simple function
> (optionally) specified in the configuration?
>

Did that, updated the 415 branch. I made that a method on botmaster now,
which seems to work rather well.

Axel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://buildbot.net/pipermail/devel/attachments/20090131/9be087cb/attachment.html>