[Buildbot-devel] jinja: user customization and public_html?

[Stefan Seefeld]

On 12/21/2009 11:34 AM, Marcus Lindblom wrote:
> On 2009-12-21 11:22, Marcus Lindblom wrote:
>    
>> On 2009-12-20 23:30, Stefan Seefeld wrote:
>>      
>>> On 12/20/2009 12:13 PM, Marcus Lindblom wrote:
>>>        
>>>> On 2009-12-20 18:08,
>>>> exarkun at twistedmatrix.com wrote:
>>>>
>>>>
>>>>          
>>>>> Sorry, I got lost in the discussion of templates and ChoiceLoaders and
>>>>> so forth.  What's the outcome of this for existing installations with
>>>>> customized public_html directories (including customized index.html
>>>>> files)?
>>>>>
>>>>>            
>>>> Hopefully nothing. We could (but don't right now) detect if a custom
>>>> index.html file exists and serve that. That's all that required to make
>>>> customized index.html pages served.
>>>>          
>>> Static html files should be served just as before. All that changes is
>>> the generation of non-static html, including directory views. Existing
>>> .html files will continue to be sent verbatim over the wire.
>>>        
>> I overrode index.html with web.RootPage():
>>
>> http://github.com/marcusl/buildbot/blob/3694085c4f0bb8db6450dd9b4cf6e08147acaa30/buildbot/status/web/baseweb.py#L584
>>
>> We need to selectively include that line depending on if index.html is
>> on disk or not.
>>      
> Or we could just move public_html\index.html to templates\root.html in
> upgradeMaster().
>
> I think that'd work nicely. What do you think?
>    

What purpose would that have ? Traditionally, any directory URL request 
is served either by sending an "index.html" file, if it exists, or 
generate a directory view. I don't see why this should change, just 
because we introduce templates. Static content can be served just as before.

Regards,
         Stefan

-- 

       ...ich hab' noch einen Koffer in Berlin...