[Buildbot-devel] jinja: user customization and public_html?

Marcus Lindblom macke at yar.nu
Sun Dec 20 18:58:55 UTC 2009


On 2009-12-20 19:03, Dustin J. Mitchell wrote:
> On Sun, Dec 20, 2009 at 11:50 AM, Marcus Lindblom<macke at yar.nu>  wrote:
>> Speaking of which, do we need to do something similar with buildbot.css
>> (which is now called default.css? I think...?)
>
> It's default.css in the source tree, but installed in public_html as
> buildbot.css.

Oops. I renamed it to default.css everywhere when merging to jinja 
branch. (I also had a buildbot.css, so I was confused.)

> It seems like the CSS should be part of the templates, right?

Yup. That ought to make the above mistake irrelevant, I hope. :-P

However, the CSS file needs to be served statically instead of via 
HtmlResource, we need to do something slightly different there.

(I thought about serving everything through twisted.web.Resource:S, but 
different templates will probably use different images/css:es, so that 
won't work)

> Maybe with some special include of buildbot-local.css if it exists?

Or just use a similar directory-overriding scheme that we plan for the 
templates?

(Perhaps we can locate data through the same loader classes? It seems a 
bit inconclusive at the moment.)

The loader docs are here:
http://jinja.pocoo.org/2/documentation/api#loaders

The good news is that FileLoader also accepts a list of directories, so 
allowing local overrides will be trivial.

Cheers,
/Marcus





More information about the devel mailing list