[Buildbot-devel] Inheritance of Properties by Triggerables

[Doug Latornell]

Thanks, Dustin.

On Thu, Apr 16, 2009 at 7:22 PM, Dustin J. Mitchell <dustin at zmanda.com> wrote:
>
> On Thu, Apr 16, 2009 at 6:44 PM, Doug Latornell <doug at sadahome.ca> wrote:
> > So, question #1: Am I right to expect that the make_refs property would be
> > passed from the Nightly or Try_Jobdir scheduler to the Triggerable
> > scheduler?  It seems like a reasonable behaviour to me.
>
> No, we don't want to automatically inherit properties.

Okay, I'll accept that, though I am curious why?

>
> > Question #2:  If the Triggerable can't or shouldn't inherit the make_refs
> > property and my work around is the correct way to do things, is there a way
> > to pass the property along without going through the WithProperties.render()
> > method so that the type of the property values doesn't get mangled (or have
> > to be managed)?
>
> Yes, this needs to be fixed.  Another user was asking about this
> recently, and I thought there was a bug for it, but I can't find it
> now.  Will you file one at buildbot.net?

Done: http://buildbot.net/trac/ticket/554

I couldn't find the other user's question that your mention in the
list archive (or at least I didn't recognize it), so the ticket is
pretty specific to my use case.

I got git and a buildbot testbed set up on my MacBook last night and
started to familiarize myself with the properties code and unit tests.
 Nice codebase you folks have built!

I'm pretty sure that I know how to implement what I want.  I've
outlined my idea in the comments on the ticket - feedback please!

Doug