[Buildbot-devel] Wrong target url when button 'Force Build' it's pressed.
exarkun at divmod.com
Tue Sep 16 19:48:03 UTC 2008
On Tue, 16 Sep 2008 12:40:30 -0700, Brian Warner <warner-buildbot at lothar.com> wrote:
>> >I suppose that the special character drives to a bad formatted url on
>> >form submit.
>> Yes, for some reason buildbot ignores branches with certain characters
>> in their name - + included - intentionally. It'd be great if it
>> didn't do this.
>Hrm, that isn't intentional. Do you have any idea where/why this is
>happening? It kind of sounds to me like we're missing a urllib.quote() on a
>branch name somewhere.
# keep weird stuff out of the branch and revision strings. TODO:
# centralize this somewhere.
if not re.match(r'^[\w\.\-\/]*$', branch):
log.msg("bad branch '%s'" % branch)
Among other things, this won't match branch names which include "+". I'm
only guessing that this is the codepath that the OP is encountering, though.
More information about the devel