[Buildbot-devel] Error using WithProperties in ShellCommand description

[Charles Lepple]

On Wed, Oct 1, 2008 at 8:24 PM, Dustin J. Mitchell <dustin at zmanda.com> wrote:
> On Wed, Oct 1, 2008 at 4:41 PM, John Stile <john at stilen.com> wrote:
>>          description=[WithProperties("%(branch)s")],
>>          descriptionDone=[WithProperties("%(branch)s:-trunk")]
>
> Unfortunately, you can't use WithProperties in these fields.
> WithProperties only applies to strings sent to the buildslave, and
> they are "expanded" at that time.

Dustin,

Apparently there is some code in ShellCommand.describe() that looks
like it would be able to support something like this (as seen in
0.7.8):

        if done and self.descriptionDone is not None:
            return self.descriptionDone
        if self.description is not None:
            return self.description

        properties = self.build.getProperties()
        words = self.command
        if isinstance(words, (str, unicode)):
            words = words.split()
        # render() each word to handle WithProperties objects
        words = properties.render(words)

Specifying either description or descriptionDone currently makes the
function return early, but maybe description and descriptionDone could
also be render()ed?

-- 
- Charles Lepple