[Buildbot-devel] SVNPoller fails to recognise a branch deletion

[Charles Lepple]

On Thu, May 1, 2008 at 3:31 PM, Brian Warner <warner-buildbot at lothar.com> wrote:
> On Thu, 1 May 2008 17:29:06 +0100
>  "Neil Hemingway" <neil.hemingway at googlemail.com> wrote:
>
>  > If I haven't missed an obvious solution, I'll create a ticket and see what I
>  > can do to patch SVNPoller
>
>  I can't think of one offhand. You could either modify the SVNPoller
>  changesource to not emit changes for branch deletions, or modify the
>  Scheduler to recognize branch deletion changes and not trigger a build in
>  response. I'm not sure which one would be cleaner.

I took a look at this once, and my understanding is that the Scheduler
sees Change objects, and a Change object only lists the files in the
original changeset, not whether the files were added, modified or
deleted.

In order to fix this in SVNPoller, you would probably have to figure
out that there are no files changing (just the branch name), and that
the change represents a deletion. Even if the Change object discards
the add/mod/delete info, it probably needs to be carried over into the
logic to determine whether or not a branch was deleted.

After checking into this, I decided to just let the builder fail when
deleting a branch/tag.

-- 
- Charles Lepple