[Buildbot-devel] Skipped step showing up yellow, not green

[Greg Ward]

The final step of my build is to copy the build output (a bunch of
.rpm files) to a build repository.  I only want this behaviour for
production builds of course: nightly builds, test builds, etc. should
skip that step.  So I coded a custom subclass of ShellCommand:

class CopyRPMs(ShellCommand):
    """
    Custom build step for copying RPMs to build repo.  Needs to be a
    custom build step because it's conditional on a build property.
    """
    def start(self):
        build_type = self.getProperty("ims_build_type")  # a custom
build property
        if build_type != "versioned":          # this is a production build
            self.step_status.setColor("green")
            self.step_status.setText(["copy rpms", "skipped"])
            return SKIPPED
        else:
            ShellCommand.start(self)

That works fine, except the SKIPPED step is showing up in the
waterfall as yellow, not green.  Am I missing something, or is this a
bug?

Greg