[Buildbot-devel] Update to 0.7.7-dustin-20080613.tar.gz results in BuildStatus error

[Bailey, Darragh]

Scrub that, I found the fix up in Dustin's darcs repo.

Line should be changed from:
        self.properties.update(propdict)
to
        self.properties.update(propdict, "Upgrade from previous version")

--
Regards,
Darragh Bailey

Systems Software Engineer
Hewlett Packard Galway Ltd.
+353 91 75-4674

Postal Address:    Hewlett Packard Galway Limited, Ballybrit Business Park, Galway
Registered Office: Hewlett Packard Galway Limited, 63-74 Sir John Rogerson's Quay Dublin 2
Registered Number: 361933

_______________________________________________
The contents of this message and any attachments to it are confidential and may be legally privileged. If you have received this message in error you should delete it from your system immediately and advise the sender.
To any recipient of this message within HP, unless otherwise stated you should consider this message and attachments as "HP CONFIDENTIAL".


> -----Original Message-----
> From: Bailey, Darragh
> Sent: 01 July 2008 14:26
> To: Bailey, Darragh; buildbot-devel at lists.sourceforge.net
> Subject: RE: [Buildbot-devel] Update to 0.7.7-dustin-20080613.tar.gz
> results in BuildStatus error
>
>
> Digging a little more into this, suggests that the problem lies in a call
> to
> Properties.update().
>
> buildbot-0.7.7-dustin/buildbot/status/builder.py adds the following
> function
> +    def upgradeToVersion3(self):
> +        # in version 3, self.properties became a Properties object
> +        propdict = self.properties
> +        self.properties = Properties()
> +        self.properties.update(propdict)
>
> I suspect the last line should actually read
> self.properties.updateFromProperties(propdict)
>
>
> --
> Regards,
> Darragh Bailey
>
> Systems Software Engineer
> Hewlett Packard Galway Ltd.
> +353 91 75-4674
>
> Postal Address:    Hewlett Packard Galway Limited, Ballybrit Business
> Park, Galway
> Registered Office: Hewlett Packard Galway Limited, 63-74 Sir John
> Rogerson's Quay Dublin 2
> Registered Number: 361933
>
> _______________________________________________
> The contents of this message and any attachments to it are confidential
> and may be legally privileged. If you have received this message in error
> you should delete it from your system immediately and advise the sender.
> To any recipient of this message within HP, unless otherwise stated you
> should consider this message and attachments as "HP CONFIDENTIAL".
>
>
> > -----Original Message-----
> > From: buildbot-devel-bounces at lists.sourceforge.net [mailto:buildbot-
> devel-
> > bounces at lists.sourceforge.net] On Behalf Of Bailey, Darragh
> > Sent: 01 July 2008 13:46
> > To: buildbot-devel at lists.sourceforge.net
> > Subject: [Buildbot-devel] Update to 0.7.7-dustin-20080613.tar.gz results
> > in BuildStatus error
> >
> >
> > There appears to be a change that requires an upgrade on the BuildStatus
> > object from version 2 (0.7.7) to version 3 (0.7.7-dustin-20080613).
> >
> > Attached is what appears in the twistd.log file on the server.
> >
> > I only upgraded the server, not the client, but this appears to be a
> > problem on the server side only, so I don't think that not upgrading the
> > client has any impact here.
> >
> >
> > --
> > Regards,
> > Darragh Bailey
> >
> > Systems Software Engineer
> > Hewlett Packard Galway Ltd.
> > +353 91 75-4674
> >
> > Postal Address:    Hewlett Packard Galway Limited, Ballybrit Business
> > Park, Galway
> > Registered Office: Hewlett Packard Galway Limited, 63-74 Sir John
> > Rogerson's Quay Dublin 2
> > Registered Number: 361933
> >
> > _______________________________________________
> > The contents of this message and any attachments to it are confidential
> > and may be legally privileged. If you have received this message in
> error
> > you should delete it from your system immediately and advise the sender.
> > To any recipient of this message within HP, unless otherwise stated you
> > should consider this message and attachments as "HP CONFIDENTIAL".
> >