[Buildbot-devel] Marking a build step as failed unless the STDOUT contains a magic string.

Matisse Enzer matisse at matisse.net
Wed Jan 23 03:34:56 UTC 2008


On Jan 22, 2008, at 8:02 AM, Daniel Svensson wrote:

> On Jan 22, 2008 4:51 PM, Matisse Enzer <matisse at matisse.net> wrote:
>>
>> I have two factory steps:
>>
>>   f1.addStep(shell.ShellCommand, command=['make', 'smoke'])
>>   f1.addStep(shell.ShellCommand, command=['make', 'languages-smoke'])
>>
>> and I need to mark each step as a failure unless the stdout  
>> contains a
>> line
>> exactly matching:
>>      ^All tests successful.$
>>
>> Is there a "best practice" for doing this sort of thing?
>
> In my setup ShellCommand is subclassed to a testclass, that overrides
> the commandComplete method to grep for result strings, and then
> evaluateCommand returns the success status, and perhaps getText2 could
> say how many tests failed etc.


Thanks - that seems like a good approach.

Also, for those who are wondering why I don't change the Makefile -  
the codebase being built isn't actually one I work on - it's the  
Parrot project and I'm just running a buildmaster for it, but am not a  
committer on the project.

-matisse

-------------------------------------------------------
Matisse Enzer <matisse at matisse.net>
http://www.matisse.net/  - http://www.eigenstate.net/







More information about the devel mailing list