[Buildbot-devel] patch for review: mail.MailNotifier support for 'passing' mode?

[Shaun McDonald]

Hi Matisse,

We done something similar, but just for the tinderbox mails. Instead  
we called the status a "fold". We also use a subclass rather than  
patching the buildbot source. Our slave scripts return the status 65  
(a number picked out of the air), and set the step to SKIPPED.

See http://ootermite.googlecode.com/svn/trunk/buildbot/buildmaster/OOtinder.py 
  for our version of the tinderbox mailer.
All files in http://ootermite.googlecode.com/svn/trunk/buildbot/ are  
based on 0.7.5 buildbot.
Files in http://ootermite.googlecode.com/svn/branches/076upgrade/ are  
working toward the 0.7.6 buildbot.

Your patch is also missing the code that sets self.mode to passing.  
Also how is this shown in the web status? These are things that we  
have dealt with in our implementation, however the webstatus doesn't  
always work right as the colour of the last step usually jumps to  
yellow rather than the grey I set them.

Shaun
On 13 Jan 2008, at 18:27, Matisse Enzer wrote:

> I wanted to send email with a different Subject line for passing
> builds, so I made the following changes to buildbot/status/mail.py
>
> This supports a new MailNotifer mode of 'passing'
>
> I wonder what you all think of this:
>
>
> --- /usr/lib/python2.4/site-packages/buildbot/status/mail.py.dist	
> 2008-01-13 09:21:23.000000000 -0800
> +++ /usr/lib/python2.4/site-packages/buildbot/status/mail.py	
> 2008-01-13 10:23:04.000000000 -0800
> @@ -208,6 +208,8 @@
>
>          if self.mode == "failing" and results != FAILURE:
>              return
> +        if self.mode == "passing" and results == SUCCESS:
> +            return
>          if self.mode == "problem":
>              if results != FAILURE:
>                  return
> @@ -228,6 +230,8 @@
>              text += "The Buildbot has finished a build of %s.\n" %
> name
>          elif self.mode == "failing":
>              text += "The Buildbot has detected a failed build of %s.
> \n" % name
> +        elif self.mode == "passing":
> +            text += "The Buildbot has detected a passing build of %s.
> \n" % name
>          else:
>              text += "The Buildbot has detected a new failure of %s.
> \n" % name
>          buildurl = self.status.getURLForThing(build)
>
>
>
>
>
> -------------------------------------------------------------------------
> Check out the new SourceForge.net Marketplace.
> It's the best place to buy or sell services for
> just about anything Open Source.
> http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
> _______________________________________________
> Buildbot-devel mailing list
> Buildbot-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/buildbot-devel