[Buildbot-devel] Buildbot 1.0: The Shimmering Vision

[Darragh Bailey]

> -----Original Message-----
> From: buildbot-devel-bounces at lists.sourceforge.net
> [mailto:buildbot-devel-bounces at lists.sourceforge.net] On Behalf Of Kai Blin
> Sent: 19 August 2008 08:58
> To: buildbot-devel at lists.sourceforge.net
> Subject: Re: [Buildbot-devel] Buildbot 1.0: The Shimmering Vision
> 
> Dan Kegel wrote:
> 
> > - a mailing list watcher / try --diff combination which:
> >
> > a) is adapted to watching a -patches (as opposed to -commits)
> > mailing
> list
> 
> I think I've got the "watching" part settled, at least for patches
> git-mailinfo can understand. I'll push a patch to my git tree for
> review once

Would you also want a main source watcher and for patchwatcher to be
notified that the baseline has changed and to resubmit and patches that
were previously built and passed but are not currently applied to the
baseline?

Would catch patches that need to be rediff'ed/changed based on committed
changes.

Or is that something for further down the line?

> > b) supports patch series (e.g. patch 2/2 should be tested in the
> > context of patch 1/2 already applied)
> 
> I'm not sure how to handle that on the buildbot side. Any ideas?

Could you use 'combinediff' from the patchutils package to send one
patch each time?

Alternative would be to modify the underlying try code to support
receiving multiple patches in a list. Would probably be easier to leave
it up to the patch watcher to determine which patches to send though.

> > c) supports baseline build caching, i.e. support for
> > prebuilding trees fetched from a slowly changing git/svn/p4
> > as a baseline for building many proposed patches from a
> > busy -patches mailing list
> 
> Won't this break for changes that require e.g. a rerun of ./configure
> or the like?

You can still rerun configure but if header files don't change, they
don't get written to (I think) and dependent files won't need to be 
rebuilt. At least that's what I remember from building the wine tree.

I think the only way to support this would be to have a separate factory
for builds that watch the git repository only. Then have the build
factories that are triggered by patchwatcher use the built tree as their
source before applying patches.

> > d) supports a patch-centric report (in addition to buildbot's
> > existing build-centric reports)
> 
> I think when treating "apply the patch" as part of the build process,
> those reports are pretty much the same.

Build bot supports including user specified log parsers so, you could 
add a custom log parser to retreive the important details required by 
patchwatcher.

> Cheers,
> Kai


-- 
Darragh

"Nothing is foolproof to a sufficiently talented fool."