[Buildbot-devel] Notifying users of events (#75 and #171)

[Dustin J. Mitchell]

On Sat, Apr 26, 2008 at 5:29 AM, Neil Hemingway
<neil.hemingway at googlemail.com> wrote:
> Following on from Brian's email commentary on #75, I'm interested in having
> buildbot be able to notify users of build events via various merchanisms.
> At the moment, I believe buildbot can only notify via email or IRC and each
> watches for event independently.  I think it makes sense to separate the
> event monitoring from the notification mechanism.  Some of this will require
> implementing some of the infrastructure needed for #75 (although not all the
> protocols).

I'm in favor of such a change.  At present, the FooStatus class
hierarchy is a combination of status-as-state and
status-as-event-stream.  I would certainly like to see those two
things separated and made more abstract and regular.  In other words,
if you're going to do this, IMHO please over-engineer rather than
under-engineer.

>  One element of Brian's email I do not anticipate creating is the
> ProblemManager.  Maybe when this is created, the EventManager could notify
> the ProblemManager of events.  Then buildbot could be configured to notify
> about events and/or problems.  Then again, maybe it would be pointless
> notifying about events if we notify about problems?

A problem is basically an event or set of events that meet some
criteria which leads to a louder notification, right?  The criteria
might be "last build on this builder was OK, this one failed", and the
grouping of events into a set might be on the basis of got_revision.
This suggests that a ProblemManager may be implemented as a filter on
an event stream.  I'm just thinking out loud here.

Dustin

-- 
Storage Software Engineer
http://www.zmanda.com