[Buildbot-devel] Maybe fixed URL in getURLForThing in builder.py

Matisse Enzer menzer at apple.com
Fri Apr 18 19:35:00 UTC 2008


This is totally trivial bug I found, I think.

The URL returned by getURLForThing in builder.py seems to be wrong.
It returns

    http://buildbot.example.com:8010/MyProject/builds/23

and should return:

    http://buildbot.example.com:8010/builders/MyProject/builds/23

Here's a teeny patch:

--- builder.py.dist	2008-04-18 12:19:41.000000000 -0700
+++ builder.py	2008-04-18 12:21:28.000000000 -0700
@@ -1802,7 +1802,7 @@
          if interfaces.IBuildStatus.providedBy(thing):
              build = thing
              builder = build.getBuilder()
-            return "%s%s/builds/%d" % (
+            return "%sbuilders/%s/builds/%d" % (
                  prefix,
                  urllib.quote(builder.getName(), safe=''),
                  build.getNumber())








More information about the devel mailing list