[Buildbot-devel] Properties for build steps

[Neil Hemingway]

I've raised a ticket (#228) to cover this and attached my patch to it.  If
there's anyone else out there testing perl, pls give it a whirl and let me
know what you think.

Neil


On 24/01/2008, Axel Hecht <l10n.moz at googlemail.com> wrote:
>
> ... and add a deprecation warning for the time that the two are in
> parallel. I think that's what Brian usually does.
>
> Note, you can probably happily fake that as good as it gets by just
> adding an array or a hash as value for the property, and to append to
> that instead of setting it. Or to do something else. I use complex
> pickle-able things in build properties myself, that's not a problem.
> And given that there are no distinct step pickle files anyway, you
> might just end up with the same thing if you implement
> setStepProperty.
>
> Axel
>
> 2008/1/24, Dustin J. Mitchell <dustin at zmanda.com>:
>
> > On Jan 23, 2008 5:00 PM, Neil Hemingway <neil.hemingway at googlemail.com>
> wrote:
> > > I don't see a problem creating setStepProperty, getStepProperty etc.
> for the
> > > step and its status object, but it'll be a little confusing to then
> have
> > > setStepProperty and setProperty.  It would seem better to rename
> setProperty
> > > as setBuildProperty, but I suspect that would break existing code.
> >
> > Good of you to worry over such a thing!
> >
> > It's Brian's call exactly how this is handled, but I'll toss in a few
> pence.
> >
> > I think that just changing the names would probably be fine,
> > particularly if a note to that effect goes into the next release
> > notes.  However, another option may be to define the functions with
> > the new names (and put the new names in the relevant interfaces), then
> > include e.g.,
> >
> >   setProperty = setBuildProperty # be compatible with old function name
> >
> > so as not to break old code.
> >
> > Dustin
> >
> > --
> > Storage Software Engineer
> > http://www.zmanda.com
> >
>
> >
> -------------------------------------------------------------------------
> > This SF.net email is sponsored by: Microsoft
> > Defy all challenges. Microsoft(R) Visual Studio 2008.
> > http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> > _______________________________________________
> > Buildbot-devel mailing list
> > Buildbot-devel at lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/buildbot-devel
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://buildbot.net/pipermail/devel/attachments/20080404/b939152f/attachment.html>