[Buildbot-devel] SVN.parseGotRevision() patch

Charles Lepple clepple at gmail.com
Tue Oct 30 23:43:45 UTC 2007


On 10/30/07, Jean-Paul Calderone <exarkun at divmod.com> wrote:
> Unrelated to your patch, except that it would touch the same part of the
> code, what I would like to see is the _removal_ of the use of svnversion
> entirely.  The information was already supplied elsewhere, and svnversion
> takes _forever_ to run on Windows.  It would almost double the speed of all
> our Windows builds if svnversion weren't run.

Agreed -- isn't the output of svnversion (no "-c") the same as the
"Checked out revision ___" message at the end of the SVN
checkout/update command, especially since buildbot now ignores the "M"
(if present)?

I would agree with Aaron that there are cases where you want the "last
changed" revision instead, but it might warrant its own property name.

-- 
- Charles Lepple




More information about the devel mailing list