[Buildbot-devel] Patches to start/stop all the builders in one click

[Brian Warner]

On Thu,  8 Nov 2007 17:51:36 +0100
Benoit Sigoure <tsuna at lrde.epita.fr> wrote:

> By the way, I think it's possible to stop a build even though
> web-based start/stop isn't enabled in the configuration.
> StatusResourceBuild::stop does not seem to check whether or not the
> web-control has been enabled.

I'm pretty sure it will throw an exception. I'm using a capabilities-style
approach here, in which (for example) the StatusResourceBuild object either
gets an IBuildControl object (in self.build_control) or it gets None, and the
only way to stop the build is through that object. The IBuildControl comes
from the parent IBuilderControl, which comes from the master IControl. The
WebStatus instances is either created with access to the IControl or without
it, and all other authority over starting/stopping builds derives from that
one master reference.

The page that generates the "Stop Build" form only emits that form if it has
an IBuildControl object, so only people who are manually creating their own
/stop URLs will see the "'NoneType' object has no attribute 'stopBuild'"
exception.

cheers,
 -Brian