[Buildbot-devel] isImportant and logging

[Charles Lepple]

On Nov 16, 2007 9:13 AM, John Bäckstrand <sandos at sandos.se> wrote:
> This isnt specifically about isImportant, actually. I am trying to
> ignore our build-number files being updated by a successful build
> (infinite loops, yey!) but it doesnt currently work.
>
> My qustion is basically how to debug something like this? How would I
> for example output to the logfile in my isImportant?
>
> Curently the snipper of master.cfg looks like:
>
> ## configure the Schedulers
>
> def isImportant(change):
>          for f in change.files:
>                  if(f != "conf/lobby_buildnumber.properties" or f !=
> "conf/session_buildnumber.properties"):
>                          return True
>
>          return False

You might want to return False if the file is the one to ignore, and
then return True if it falls off the end of the for loop. This would
catch the case where a property file is updated at the same time as an
important file.

-- 
- Charles Lepple