[Buildbot-devel] MailNotifier "blame" email generating wrong url to build in 0.7.6

[Stephen Davis]

I have a MailNotifier set up to send nastygrams to people who break  
the build and just noticed that the upgrade to 0.7.6 broke the URL  
link generated for the build which failed.  The link that is in the  
email results in a 404 error on the build master web server.

---
The Buildbot has detected a new failure of Mac TOT on MyApp.
Full details are available at:
  http://buildmaster.mycompany.com/Mac%20TOT/builds/9456

Buildbot URL: http://buildmaster.mycompany.com/

Buildslave for this Build: bumblebee2

Build Reason:
Build Source Stamp: HEAD
Blamelist: sdavis

BUILD FAILED: failed compile

sincerely,
  -The Buildbot
---

The "full details" URL is incorrect and results in a 404.  The actual  
URL is more like:

http://buildmaster.mycompany.com/builders/Mac%20TOT/builds/9456

I'm not 100% sure that is the correct URL since it appears there is  
now more than one way to get to a page representing a particular build 
(er).

Anyway, regardless of what the correct URL is supposed to be, I got  
lost in the code trying to find the right place to fix it.  It's  
based off the call to "getURLForThing(build)" in buildbot/status/ 
mail.py on line 226 but I was unable to follow it much past that (my  
python foo is pretty weak).

Has anyone else seen this problem and is there an easy fix for it?

thanks,
stephen

P.S.  This *kind* of looks like it might be related to ticket #113 b/ 
c I am in fact behind an Apache reverse proxy but I don't think it's  
the proxy causing the problem since just adding "/builders/" to the  
URL makes it work.