[Buildbot-devel] Cannot get sendchange to work

[Casey Dahlin]

Brian Warner wrote:
>> I get these two lines:
>>
>> 2007/10/31 15:51 EDT [Broker,8,127.0.0.1] Peer will receive following PB 
>> traceback:
>> 2007/10/31 15:51 EDT [Broker,8,127.0.0.1] Failure: 
>> twisted.cred.error.UnauthorizedLogin:
>>
>> Sendchange doesn't take a password.
>>     
>
> That's right, sendchange uses the same access path as buildslaves do, with a
> fixed username/password of "change"/"changepw". (one day, maybe when we move
> to Foolscap, all of this will be properly secure, but at the moment attackers
> can submit bogus changes and trick you into doing spurious rebuilds of pre-existing
> code).
>
> However, the error message is suggesting exactly a login problem. If there
> weren't a PBChangeSource registered, that might be how it would look. It would also
> look like that if the sendchange process were connecting to the wrong port,
> like, say, the PBListener status port.
>
> I think we have exactly two PB ports being used:
>
>  c['slaveport'] : used for all buildslaves, the PBChangeSource, c['debugpw']
>
>  PBListener(port=) : used for status port
>   
You got it :) I initially did not have a PBListener, and when I added it 
I supposed that that was where I needed to send the change. Guess I was 
right the first time.

Thanks for the help :)
>
> Could you double-check that you're passing a --master argument to 'buildbot
> sendchange' that references the slaveport instead of a PBListener port?
>
> If so, there might be a bug in the way the PBChangeSource is being set up,
> but I think it's been working ok for me. What are the versions of your
> buildmaster and your 'buildbot sendchange' code?
>
>   
>> Is there some kind of whitelisting I need to do?
>>     
>
> Nope.
>
> puzzled,
>  -Brian
>