[Buildbot-devel] Slave concurrency?

[Dustin J. Mitchell]

On Fri, Jun 22, 2007 at 04:56:04PM -0400, Jean-Paul Calderone wrote:
> I quickly skimmed the two patches and two things struck me:
> 
>   * there were no new unit tests or changes to existing unit tests.  I can't
>     decide which of these two things is more alarming.

I would say that the lack of changes to existing unit tests would be a
good thing, if it had been intentional.  To be honest, I didn't realize
there *were* tests -- I saw the 'test' directory that's a sibling of
'buildbot', and noted that it didn't seem to contain a testing
framework.

I'll send updated patches with the relevant test changes soon.

>   * Changing the name of the isAvailable method will break any third-party
>     modules which overrode or called this method.  It would be better to
>     leave the method name alone or provide a backward compatibility layer.

That's fair -- I'll revert the name.

Dustin

-- 
        Dustin J. Mitchell
        Storage Software Engineer, Zmanda, Inc.
        http://www.zmanda.com/