[Buildbot-devel] Branch name restrictions

[Jean-Paul Calderone]

The web form which allows builds to be forced on a particular SVN branch rejects certain branch names:

        # keep weird stuff out of the branch and revision strings. TODO:
        # centralize this somewhere.
        if not re.match(r'^[\w\.\-\/]*$', branch):
            log.msg("bad branch '%s'" % branch)
            return Redirect("..")

What's the point of this?  It seems like it serves little purpose other than
to prevent legitimate use.  If anything, the check to make here is whether a
branch with the given name actually exists in the repository.

Jean-Paul