[Buildbot-devel] trouble with sendchange

[Cavanagh, Sean (Sean)]

Hello,

 

I've been very impressed with the number of ways to get changes from CVS
into buildbot.  Unfortunately, many of those methods have failed to work
out for me, and I've worked my way up to using sendchange.

 

I'm suffering a bug when attempting to use the Sender class in
buildbot/clients/sendchange.py, like so:

    s = Sender(master,guilty_party)

    d = s.send(branch,revision,log,files)

    d.addCallbacks(s.printSuccess,s.printFailure)

    d.addBoth(s.stop)

    s.run()

 

 

After adding the callbacks in a similar method to the sendchange
function in master.py, and calling s.run() on the sender object, I get
the following output:

 

change NOT sent

[Failure instance: Traceback from remote host -- Traceback (most recent
call last):

  File "/usr/lib/python2.5/site-packages/twisted/internet/defer.py",
line 107, in maybeDeferred

    result = f(*args, **kw)

  File "/usr/lib/python2.5/site-packages/buildbot/master.py", line 101,
in attached

    d.addCallback(_log_attachment_on_slave)

  File "/usr/lib/python2.5/site-packages/twisted/internet/defer.py",
line 191, in addCallback

    callbackKeywords=kw)

  File "/usr/lib/python2.5/site-packages/twisted/internet/defer.py",
line 182, in addCallbacks

    self._runCallbacks()

--- <exception caught here> ---

  File "/usr/lib/python2.5/site-packages/twisted/internet/defer.py",
line 317, in _runCallbacks

    self.result = callback(self.result, *args, **kw)

  File "/usr/lib/python2.5/site-packages/buildbot/master.py", line 98,
in _log_attachment_on_slave

    d1 = bot.callRemote("print", "attached")

exceptions.AttributeError: 'NoneType' object has no attribute
'callRemote'

]

 

It seems as though the 'attached' method in the BotPerspective class is
receiving 'None' for the bot argument.  I assume this REALLY isn't
supposed to happen since there is no error checking for it.

 

I'm running builbot 0.7.5 and twisted 2.5.0.  Am I being bit by a
compatibility issue here?

 

So this is my first real tangle with twisted, and I'm sifting through
RPC's and callback spagetthi.  I'm hoping someone out there can shed
some light on the following questions:

 

1.	What is this 'bot' supposed to be an instance of?
2.	Who generates it?
3.	Who calls the 'attached' method, and why?

 

"A man is stuck at the bottom of the pit, unable to climb out.  A
stranger passes by and the man calls out 'Hey buddy, can you help me out
here?'  The stranger jumps into the hole.  The man says 'What did you do
that for?  Now we're both stuck down here!'  The stranger says 'Yeah,
but I've been down here before, and I know the way out!'" - I got it
from The West Wing, but I'm sure they got it from somewhere else...

 

Thanks,

 

Sean C.

 

	Sean Cavanagh | Software QA Manager | Communication Appliances
Division | P2P Business

	Avaya | 1135 Innovation Drive Suite 100 | Ottawa, ON K2K 3J7

	613.592.4343 x239 | scavanagh at avaya.com
<mailto:scavanagh at avaya.com> 

 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://buildbot.net/pipermail/devel/attachments/20070601/8cd127aa/attachment.html>