[Buildbot-devel] [Monotone-devel] Help request with buildbot for monotone
Nathaniel Smith
njs at pobox.com
Wed Jul 11 01:52:09 UTC 2007
On Tue, Jul 10, 2007 at 09:36:04AM +0200, Markus Schiltknecht wrote:
> Richard Levitte wrote:
> > Small point: in monotone.py, you've added '"--last", "20"' just before
> > the addition of depth_arg. A bit unnecessary, wouldn't you say?
>
> Uh... right. I must have overlooked the code just above that line. You
> can just remove the "--last", "20" arguments. I'm just wondering how
> often log() is called with depth=None, that would be expensive.
IIRC the log code is mostly just used to get the text that's shown
when you click on the "what changed?" link in buildbot?
> I don't particularly like that change detection code. I'm tempted to
> code a simple listener, which should get called by netsync lua hooks to
> trigger a build from the buildbot server. That seems just better than
> polling and would probably drop the requirement of the buildbot server
> to have a full repository database.
Polling is a little annoying, but useful when people can't use
sendchange... I forget how the buildbot poller works, but the CIA
poller at contrib/ciabot_monotone.py in monotone's source tree uses a
nice algorithm that's fully against the automate interface.
OTOH, one can use sendchange in a poll-based setup, by just installing
the hooks on a local database and then using a cronjob to pull into
that database (and thus trigger the hooks).
-- Nathaniel
--
Electrons find their paths in subtle ways.
More information about the devel
mailing list