[Buildbot-devel] [Monotone-devel] Help request with buildbot for monotone

[Markus Schiltknecht]

Hi,

[ CC'ing to the buildbot-devel list ]

Richard Levitte wrote:
> Small point: in monotone.py, you've added '"--last", "20"' just before
> the addition of depth_arg.  A bit unnecessary, wouldn't you say?

Uh... right. I must have overlooked the code just above that line. You 
can just remove the "--last", "20" arguments. I'm just wondering how 
often log() is called with depth=None, that would be expensive.

I don't particularly like that change detection code. I'm tempted to 
code a simple listener, which should get called by netsync lua hooks to 
trigger a build from the buildbot server. That seems just better than 
polling and would probably drop the requirement of the buildbot server 
to have a full repository database.

Regards

Markus