[Buildbot-devel] [path] mercurial hook

Brian Warner warner-buildbot at lothar.com
Mon Jul 2 09:26:44 UTC 2007


Frederic Leroy <fredo at starox.org> writes:
>
> The current mercurial hook (hg_buildbot.py) in contrib is buggy.
> I updated it a bit, at least to make it work.

Thanks for the patch! I've just applied it.

> +files = s.readline().strip()

This line is problematic: the Change object expects a list of filenames,
whereas 'hg log' emits a single line in which the filenames are separated by
spaces. I added a .split() to that line to fix it, otherwise the Change
things we have a bunch of one-character-long filenames.

Unfortunately, I can't find a way to get hg to emit filenames differently.
This approach will have problems when used with filenames that contain
spaces. Darcs and SVN offer XML-formatted output that's a bit more reliable
(and annoying) to parse.. maybe hg offers something similar?

thanks!
 -Brian




More information about the devel mailing list