[Buildbot-devel] P4Source last_change across restart

[Scott Lamb]

While preparing a huge optimization to P4Source (should be in a  
separate email, if I used darcs correctly), I noticed that its  
self.last_change is not retained across restarts. So it always misses  
changes that happen while it is down.

This is easy to spot. It contains this code:

             if last_change is None:
                 log.msg('P4Poller: starting at change %d' % num)
                 self.last_change = num
                 return []

and every time a buildbot with a P4Source starts, it says something  
like this:

     2007/02/23 18:10 PST [-] P4Poller: starting at change 6

Is there supposed to be some magic that retains state automatically?  
If so, it's not working. I see this (related?) magic "compare_attrs"  
property, but I'm not sure exactly what it does or how it's supposed  
to work.

Best regards,
Scott

-- 
Scott Lamb <http://www.slamb.org/>